Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update printer.ts to support kind = 'get'/'set' on TSMethodSignature #1383

Merged
merged 3 commits into from
May 31, 2024

Conversation

dandean
Copy link
Contributor

@dandean dandean commented Jan 3, 2024

TSMethodSignature has a kind property which can be set to method (the default), get, and set. When get and set, the method is a getter or a setter, and as such, should be prefixed with either get or set .

`TSMethodSignature` has a `kind` property which can be set to `method` (the default), `get`, and `set`. When `get` and `set`, the method is a getter or a setter, and as such, should be prefixed with either `get ` or `set `.
@coderaiser
Copy link
Contributor

Could you please add test for this? Or provide code example

@coderaiser
Copy link
Contributor

Added tests #1401 and landed in @putout/recast@1.16.0

@dandean
Copy link
Contributor Author

dandean commented May 30, 2024

@coderaiser Apologies for the delayed response, and thank you for adding the tests! Would you like me to take additional action, or is it handled as needed in #1401?

@coderaiser
Copy link
Contributor

Some checks are failing in my PR, so if you fix this in your PR, I think it can make things go a bit faster :)...

@eventualbuddha eventualbuddha merged commit 6f7466e into benjamn:master May 31, 2024
6 checks passed
@eventualbuddha
Copy link
Collaborator

Published in v0.23.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants